Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(*): unsubscribe with takeUntilDestroyed #1632

Merged
merged 4 commits into from
Aug 1, 2023
Merged

refactor(*): unsubscribe with takeUntilDestroyed #1632

merged 4 commits into from
Aug 1, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 28, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 28, 2023 •
edited
Loading

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #1632 (bb4d255) into master (2c7def7) will decrease coverage by 0.05%.
The diff coverage is 97.10%.

❗ Current head bb4d255 differs from pull request most recent head 73d8cfc. Consider uploading reports for the commit 73d8cfc to get more accurate results

@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
- Coverage   95.56%   95.51%   -0.05%     
==========================================
  Files         277      277              
  Lines        8604     8560      -44     
  Branches     1681     1681              
==========================================
- Hits         8222     8176      -46     
- Misses        317      319       +2     
  Partials       65       65
Files Changed Coverage Δ
...kages/abc/global-footer/global-footer.component.ts 93.10% <83.33%> (-3.57%) ⬇️
...kages/theme/layout-default/layout-nav.component.ts 96.34% <83.33%> (-0.63%) ⬇️
packages/abc/avatar-list/avatar-list.component.ts 100.00% <100.00%> (ø)
...kages/abc/error-collect/error-collect.component.ts 100.00% <100.00%> (ø)
packages/abc/exception/exception.component.ts 100.00% <100.00%> (ø)
...ackages/abc/full-content/full-content.component.ts 100.00% <100.00%> (ø)
packages/abc/media/media.component.ts 98.07% <100.00%> (-0.11%) ⬇️
packages/abc/page-header/page-header.component.ts 97.75% <100.00%> (-0.08%) ⬇️
packages/abc/pdf/pdf.component.ts 38.65% <100.00%> (-0.77%) ⬇️
packages/abc/result/result.component.ts 100.00% <100.00%> (ø)
... and 9 more

@cipchk cipchk merged commit 810ba02 into master Aug 1, 2023
8 checks passed
@cipchk cipchk deleted the issues-takeUntilDestroyed branch August 1, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipchk @ng-alain-bot